Whykioh/watchgether-api
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix remove/mark-watched not working on common-list movies

Browse Source 
getLists() returned the common list via MAX(id) grouped across both
users' rows, so the id handed back could belong to either partner.
remove()/markWatched() scope by (id, user_id), so whenever it picked
the partner's id, the query silently matched zero rows while still
reporting success.

Now each user's own is_common=1 rows are returned directly, so the id
is always theirs. Also fixes the frontend never recognizing common
movies as "already added" (see watchgether-web).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Noah CIBOT NOËL
2026-07-12 21:23:04 +02:00
parent c668629268
commit 2283c94a22
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
models/Movie.php
+5 -7
View File
@@ -63,13 +63,11 @@ class Movie {
} }
// 3. Commune // 3. Commune
$stmt = $this->db->prepare(" // On renvoie MA propre ligne (pas une fusion avec celle du/de la partenaire) :
SELECT MAX(id) as id, tmdb_id, title, poster_path, media_type, is_common, MAX(added_at) as added_at // chacun a sa propre ligne is_common=1 pour le même film, et remove/mark-watched
FROM movies // ont besoin de MON id pour agir sur MA ligne, pas une autre.
WHERE is_common = 1 AND (user_id = ? OR user_id = ?) $stmt = $this->db->prepare("SELECT * FROM movies WHERE user_id = ? AND is_common = 1 ORDER BY added_at DESC");
GROUP BY tmdb_id, title, poster_path, media_type, is_common $stmt->execute([$myId]);
");
$stmt->execute([$myId, $partnerId]);
$common = $stmt->fetchAll(PDO::FETCH_ASSOC); $common = $stmt->fetchAll(PDO::FETCH_ASSOC);
return ["perso" => $perso, "partner" => $partner, "common" => $common]; return ["perso" => $perso, "partner" => $partner, "common" => $common];